Fix the file extension of model checkpoints uploaded by NeptuneLogger #20581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
NeptuneLogger.after_save_checkpoint()
will upload the last and the best model checkpoint usinginstead of
In addition to reducing a couple of lines of code, this will cause the file extension of the checkpoint to appear correctly as
.ckpt
instead of.bin
.The current code already uploads the best k models this way.
To me this seems like a pretty trivial fix, but I can start a discussion if needed. Maybe some of the previous authors of
NeptuneLogger
can comment if it was written as it is on purpose? @shnela @Raalsky @williamFalcon @kshitij12345PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20581.org.readthedocs.build/en/20581/