fix compatibility for pytest 8 #20575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The test
test_seed_stays_same_with_multiple_seed_everything_calls
is only compatible withpytest==7
, but notpytest==8
due to its passingNone
topytest.warns()
, which is deprecated.This PR fixes the test by making it compatible with both
pytest
7 & 8.more context:
We (Google) uses a monorepo that enforces the pytest version to be 8 for now.
We want to be able to run the unit tests instead of just importing the code.
So, we would like to make this compatibility fix.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20575.org.readthedocs.build/en/20575/