Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ignore for hyper params #20213

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
  • Loading branch information
pre-commit-ci[bot] committed Aug 19, 2024
commit 360653e488055cd01bd1e6ef2dd3c9ede6af91b1
4 changes: 2 additions & 2 deletions src/lightning/pytorch/utilities/parsing.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
import inspect
import pickle
import types
from argparse import Namespace
from dataclasses import fields, is_dataclass
from typing import Any, Dict, List, Literal, MutableMapping, Optional, Sequence, Tuple, Type, Union
from argparse import Namespace

from torch import nn

Expand Down Expand Up @@ -205,7 +205,7 @@ def save_hyperparameters(

# filter out hp based on ignore list
if isinstance(hp, Namespace):
hp = vars(hp)
hp = vars(hp)
hp = {k: v for k, v in hp.items() if k not in ignore}
obj._set_hparams(hp)

Expand Down
Loading