Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the lightning app code #20039

Merged
merged 13 commits into from
Jul 5, 2024
Merged

Remove the lightning app code #20039

merged 13 commits into from
Jul 5, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 2, 2024

What does this PR do?

Deletes the source code under src/lightning/app, the corresponding tests, docs, ci workflows and related configuration.
Fixes GHSA-mr7h-w2qc-ffc2
Fixes CVE-2024-5980


📚 Documentation preview 📚: https://pytorch-lightning--20039.org.readthedocs.build/en/20039/

cc @Borda @carmocca @justusschock @awaelchli

@github-actions github-actions bot added docs Documentation related ci Continuous Integration app (removed) Generic label for Lightning App package pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file package labels Jul 2, 2024
@awaelchli awaelchli added this to the 2.4 milestone Jul 2, 2024
@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jul 2, 2024
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@awaelchli awaelchli marked this pull request as ready for review July 3, 2024 20:22
Copy link
Contributor

github-actions bot commented Jul 3, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-13, lightning, 3.8, 2.1, oldest) success
pl-cpu (macOS-14, lightning, 3.10, 2.1) success
pl-cpu (macOS-14, lightning, 3.10, 2.2) success
pl-cpu (macOS-14, lightning, 3.10, 2.3) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 2.1, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.3) success
pl-cpu (windows-2022, lightning, 3.8, 2.1, oldest) success
pl-cpu (windows-2022, lightning, 3.10, 2.1) success
pl-cpu (windows-2022, lightning, 3.10, 2.2) success
pl-cpu (windows-2022, lightning, 3.10, 2.3) success
pl-cpu (macOS-14, pytorch, 3.8, 2.1) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 2.1) success
pl-cpu (windows-2022, pytorch, 3.8, 2.1) success
pl-cpu (macOS-12, pytorch, 3.11, 2.1) success
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1) success
pl-cpu (windows-2022, pytorch, 3.11, 2.1) success

These checks are required after the changes to .actions/assistant.py, src/lightning/fabric/cli.py, pyproject.toml.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to .actions/assistant.py, src/lightning/__init__.py, src/lightning/__setup__.py, pyproject.toml, src/lightning/fabric/cli.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success

These checks are required after the changes to src/lightning/fabric/cli.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to src/lightning/fabric/cli.py, .github/workflows/docs-build.yml, setup.py, pyproject.toml.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to docs/source-pytorch/versioning.rst, .actions/assistant.py, .github/workflows/docs-build.yml, setup.py, pyproject.toml.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.10, 2.1, 12.1.0) success
build-cuda (3.10, 2.2, 12.1.0) success
build-cuda (3.11, 2.1, 12.1.0) success
build-cuda (3.11, 2.2, 12.1.0) success
build-pl (3.10, 2.1, 12.1.0) success
build-pl (3.10, 2.2, 12.1.0) success
build-pl (3.11, 2.1, 12.1.0) success
build-pl (3.11, 2.2, 12.1.0) success

These checks are required after the changes to .actions/assistant.py, setup.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-13, lightning, 3.8, 2.1, oldest) success
fabric-cpu (macOS-14, lightning, 3.11, 2.1) success
fabric-cpu (macOS-14, lightning, 3.11, 2.2) success
fabric-cpu (macOS-14, lightning, 3.10, 2.3) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 2.1, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success
fabric-cpu (windows-2022, lightning, 3.8, 2.1, oldest) success
fabric-cpu (windows-2022, lightning, 3.11, 2.1) success
fabric-cpu (windows-2022, lightning, 3.11, 2.2) success
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success
fabric-cpu (macOS-14, fabric, 3.8, 2.1) success
fabric-cpu (ubuntu-20.04, fabric, 3.8, 2.1) success
fabric-cpu (windows-2022, fabric, 3.8, 2.1) success
fabric-cpu (macOS-12, fabric, 3.11, 2.1) success
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1) success
fabric-cpu (windows-2022, fabric, 3.11, 2.1) success

These checks are required after the changes to .actions/assistant.py, src/lightning/fabric/cli.py, pyproject.toml.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success
lightning-fabric (GPUs) (testing Lightning | latest) success

These checks are required after the changes to .actions/assistant.py, src/lightning/__init__.py, src/lightning/__setup__.py, src/lightning/fabric/cli.py, pyproject.toml.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to .actions/assistant.py, .github/workflows/code-checks.yml, requirements/app/app.txt, requirements/app/cloud.txt, requirements/app/components.txt, requirements/app/test.txt, requirements/app/ui.txt, src/app-ui-version.info, src/lightning/__init__.py, src/lightning/__main__.py, src/lightning/__setup__.py, src/lightning/app/__init__.py, src/lightning/app/api/__init__.py, src/lightning/app/api/http_methods.py, src/lightning/app/api/request_types.py, src/lightning/app/cli/__init__.py, src/lightning/app/cli/app-template/LICENSE, src/lightning/app/cli/app-template/app.py, src/lightning/app/cli/app-template/placeholdername/__init__.py, src/lightning/app/cli/app-template/placeholdername/components/component_a/__init__.py, src/lightning/app/cli/app-template/placeholdername/components/component_a/component_a.py, src/lightning/app/cli/app-template/placeholdername/components/component_b/__init__.py, src/lightning/app/cli/app-template/placeholdername/components/component_b/component_a.py, src/lightning/app/cli/app-template/requirements.txt, src/lightning/app/cli/app-template/setup.py, src/lightning/app/cli/app-template/tests/__init__.py, src/lightning/app/cli/app-template/tests/requirements.txt, src/lightning/app/cli/app-template/tests/test_placeholdername_app.py, src/lightning/app/cli/cmd_apps.py, src/lightning/app/cli/cmd_init.py, src/lightning/app/cli/cmd_install.py, src/lightning/app/cli/cmd_pl_init.py, src/lightning/app/cli/cmd_react_ui_init.py, src/lightning/app/cli/commands/__init__.py, src/lightning/app/cli/commands/app_commands.py, src/lightning/app/cli/commands/cd.py, src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/logs.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/commands/pwd.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/component-template/LICENSE, src/lightning/app/cli/component-template/app.py, src/lightning/app/cli/component-template/placeholdername/__init__.py, src/lightning/app/cli/component-template/placeholdername/component.py, src/lightning/app/cli/component-template/requirements.txt, src/lightning/app/cli/component-template/setup.py, src/lightning/app/cli/component-template/tests/__init__.py, src/lightning/app/cli/component-template/tests/requirements.txt, src/lightning/app/cli/component-template/tests/test_placeholdername_component.py, src/lightning/app/cli/connect/__init__.py, src/lightning/app/cli/connect/app.py, src/lightning/app/cli/connect/data.py, src/lightning/app/cli/core.py, src/lightning/app/cli/lightning_cli.py, src/lightning/app/cli/lightning_cli_delete.py, src/lightning/app/cli/lightning_cli_launch.py, src/lightning/app/cli/lightning_cli_list.py, src/lightning/app/cli/pl-app-template/app.py, src/lightning/app/cli/pl-app-template/core/__init__.py, src/lightning/app/cli/pl-app-template/core/callbacks.py, src/lightning/app/cli/pl-app-template/core/components/__init__.py, src/lightning/app/cli/pl-app-template/core/components/logger/__init__.py, src/lightning/app/cli/pl-app-template/core/components/logger/tensorboard.py, src/lightning/app/cli/pl-app-template/core/components/logger/weights_and_biases.py, src/lightning/app/cli/pl-app-template/core/components/script_runner/__init__.py, src/lightning/app/cli/pl-app-template/core/components/script_runner/script_runner.py, src/lightning/app/cli/pl-app-template/core/state.py, src/lightning/app/cli/pl-app-template/setup.py, src/lightning/app/cli/pl-app-template/tests/__init__.py, src/lightning/app/cli/pl-app-template/tests/core/__init__.py, src/lightning/app/cli/pl-app-template/tests/core/test_callbacks.py, src/lightning/app/cli/pl-app-template/tests/test_app.py, src/lightning/app/cli/pl-app-template/ui/craco.config.js, src/lightning/app/cli/pl-app-template/ui/package.json, src/lightning/app/cli/pl-app-template/ui/public/favicon.svg, src/lightning/app/cli/pl-app-template/ui/public/index.html, src/lightning/app/cli/pl-app-template/ui/public/manifest.json, src/lightning/app/cli/pl-app-template/ui/public/robots.txt, src/lightning/app/cli/pl-app-template/ui/src/App.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/EnvironmentConfigurator.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/ErrorPanel.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/ExecutionSummary.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/HyperparameterSummary.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/Launcher.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/ProgressBar.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/ProgressBarGroup.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/Timer.tsx, src/lightning/app/cli/pl-app-template/ui/src/hooks/useLightningState.ts, src/lightning/app/cli/pl-app-template/ui/src/index.css, src/lightning/app/cli/pl-app-template/ui/src/index.tsx, src/lightning/app/cli/pl-app-template/ui/src/lightning-colors.ts, src/lightning/app/cli/pl-app-template/ui/src/react-app-env.d.ts, src/lightning/app/cli/pl-app-template/ui/src/reportWebVitals.ts, src/lightning/app/cli/pl-app-template/ui/src/types/lightning.ts, src/lightning/app/cli/pl-app-template/ui/tsconfig.json, src/lightning/app/cli/react-ui-template/example_app.py, src/lightning/app/cli/react-ui-template/ui/index.html, src/lightning/app/cli/react-ui-template/ui/package.json, src/lightning/app/cli/react-ui-template/ui/src/App.css, src/lightning/app/cli/react-ui-template/ui/src/App.tsx, src/lightning/app/cli/react-ui-template/ui/src/favicon.svg, src/lightning/app/cli/react-ui-template/ui/src/hooks/useLightningState.ts, src/lightning/app/cli/react-ui-template/ui/src/index.css, src/lightning/app/cli/react-ui-template/ui/src/main.tsx, src/lightning/app/cli/react-ui-template/ui/src/types/lightning.ts, src/lightning/app/cli/react-ui-template/ui/src/vite-env.d.ts, src/lightning/app/cli/react-ui-template/ui/tsconfig.json, src/lightning/app/cli/react-ui-template/ui/tsconfig.node.json, src/lightning/app/cli/react-ui-template/ui/vite.config.ts, src/lightning/app/cli/react-ui-template/ui/yarn.lock, src/lightning/app/components/__init__.py, src/lightning/app/components/database/__init__.py, src/lightning/app/components/database/client.py, src/lightning/app/components/database/server.py, src/lightning/app/components/database/utilities.py, src/lightning/app/components/multi_node/__init__.py, src/lightning/app/components/multi_node/base.py, src/lightning/app/components/multi_node/fabric.py, src/lightning/app/components/multi_node/pytorch_spawn.py, src/lightning/app/components/multi_node/trainer.py, src/lightning/app/components/python/__init__.py, src/lightning/app/components/python/popen.py, src/lightning/app/components/python/tracer.py, src/lightning/app/components/serve/__init__.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/catimage.png, src/lightning/app/components/serve/cold_start_proxy.py, src/lightning/app/components/serve/gradio_server.py, src/lightning/app/components/serve/python_server.py, src/lightning/app/components/serve/serve.py, src/lightning/app/components/serve/streamlit.py, src/lightning/app/components/serve/types/__init__.py, src/lightning/app/components/serve/types/image.py, src/lightning/app/components/serve/types/type.py, src/lightning/app/components/training.py, src/lightning/app/core/__init__.py, src/lightning/app/core/api.py, src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/core/flow.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/frontend/__init__.py, src/lightning/app/frontend/frontend.py, src/lightning/app/frontend/just_py/__init__.py, src/lightning/app/frontend/just_py/just_py.py, src/lightning/app/frontend/just_py/just_py_base.py, src/lightning/app/frontend/panel/__init__.py, src/lightning/app/frontend/panel/app_state_comm.py, src/lightning/app/frontend/panel/app_state_watcher.py, src/lightning/app/frontend/panel/panel_frontend.py, src/lightning/app/frontend/panel/panel_serve_render_fn.py, src/lightning/app/frontend/stream_lit.py, src/lightning/app/frontend/streamlit_base.py, src/lightning/app/frontend/utils.py, src/lightning/app/frontend/web.py, src/lightning/app/launcher/__init__.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/launcher/lightning_hybrid_backend.py, src/lightning/app/launcher/utils.py, src/lightning/app/pdb/__init__.py, src/lightning/app/pdb/pdb.py, src/lightning/app/plugin/__init__.py, src/lightning/app/plugin/plugin.py, src/lightning/app/runners/__init__.py, src/lightning/app/runners/backends/__init__.py, src/lightning/app/runners/backends/backend.py, src/lightning/app/runners/backends/cloud.py, src/lightning/app/runners/backends/docker.py, src/lightning/app/runners/backends/mp_process.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/multiprocess.py, src/lightning/app/runners/runtime.py, src/lightning/app/runners/runtime_type.py, src/lightning/app/source_code/__init__.py, src/lightning/app/source_code/copytree.py, src/lightning/app/source_code/hashing.py, src/lightning/app/source_code/local.py, src/lightning/app/source_code/tar.py, src/lightning/app/source_code/uploader.py, src/lightning/app/storage/__init__.py, src/lightning/app/storage/copier.py, src/lightning/app/storage/drive.py, src/lightning/app/storage/filesystem.py, src/lightning/app/storage/mount.py, src/lightning/app/storage/orchestrator.py, src/lightning/app/storage/path.py, src/lightning/app/storage/payload.py, src/lightning/app/storage/requests.py, src/lightning/app/structures/__init__.py, src/lightning/app/structures/dict.py, src/lightning/app/structures/list.py, src/lightning/app/testing/__init__.py, src/lightning/app/testing/config.py, src/lightning/app/testing/helpers.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/__init__.py, src/lightning/app/utilities/app_commands.py, src/lightning/app/utilities/app_helpers.py, src/lightning/app/utilities/app_logs.py, src/lightning/app/utilities/app_status.py, src/lightning/app/utilities/auth.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/cloud.py, src/lightning/app/utilities/clusters.py, src/lightning/app/utilities/commands/__init__.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/component.py, src/lightning/app/utilities/data_structures.py, src/lightning/app/utilities/dependency_caching.py, src/lightning/app/utilities/enum.py, src/lightning/app/utilities/exceptions.py, src/lightning/app/utilities/frontend.py, src/lightning/app/utilities/git.py, src/lightning/app/utilities/imports.py, src/lightning/app/utilities/introspection.py, src/lightning/app/utilities/layout.py, src/lightning/app/utilities/load_app.py, src/lightning/app/utilities/log.py, src/lightning/app/utilities/log_helpers.py, src/lightning/app/utilities/login.py, src/lightning/app/utilities/logs_socket_api.py, src/lightning/app/utilities/name_generator.py, src/lightning/app/utilities/network.py, src/lightning/app/utilities/openapi.py, src/lightning/app/utilities/packaging/__init__.py, src/lightning/app/utilities/packaging/app_config.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/app/utilities/packaging/cloud_compute.py, src/lightning/app/utilities/packaging/docker.py, src/lightning/app/utilities/packaging/lightning_utils.py, src/lightning/app/utilities/packaging/tarfile.py, src/lightning/app/utilities/port.py, src/lightning/app/utilities/proxies.py, src/lightning/app/utilities/redis.py, src/lightning/app/utilities/safe_pickle.py, src/lightning/app/utilities/scheduler.py, src/lightning/app/utilities/secrets.py, src/lightning/app/utilities/state.py, src/lightning/app/utilities/tracer.py, src/lightning/app/utilities/tree.py, src/lightning/app/utilities/types.py, src/lightning/app/utilities/warnings.py, src/lightning/fabric/cli.py, src/lightning/store/__init__.py, src/lightning/store/store.py, src/lightning/store/utils.py, src/lightning_app/MANIFEST.in, src/lightning_app/__about__.py, src/lightning_app/__main__.py, src/lightning_app/__setup__.py, src/lightning_app/__version__.py, src/lightning_app/py.typed, src/lightning_app/shell-folder_code-lives-lightning.info, pyproject.toml.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.8) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.8) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.8) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.8) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-12, fabric, 3.8) success
install-pkg (macOS-12, fabric, 3.11) success
install-pkg (macOS-12, pytorch, 3.8) success
install-pkg (macOS-12, pytorch, 3.11) success
install-pkg (macOS-12, lightning, 3.8) success
install-pkg (macOS-12, lightning, 3.11) success
install-pkg (macOS-12, notset, 3.8) success
install-pkg (macOS-12, notset, 3.11) success
install-pkg (windows-2022, fabric, 3.8) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.8) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.8) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.8) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to .actions/assistant.py, .github/actions/pkg-install/action.yml, .github/workflows/_build-packages.yml, .github/workflows/ci-pkg-install.yml, setup.py, src/app-ui-version.info, src/lightning/__init__.py, src/lightning/__main__.py, src/lightning/__setup__.py, src/lightning/app/__init__.py, src/lightning/app/api/__init__.py, src/lightning/app/api/http_methods.py, src/lightning/app/api/request_types.py, src/lightning/app/cli/__init__.py, src/lightning/app/cli/app-template/LICENSE, src/lightning/app/cli/app-template/app.py, src/lightning/app/cli/app-template/placeholdername/__init__.py, src/lightning/app/cli/app-template/placeholdername/components/component_a/__init__.py, src/lightning/app/cli/app-template/placeholdername/components/component_a/component_a.py, src/lightning/app/cli/app-template/placeholdername/components/component_b/__init__.py, src/lightning/app/cli/app-template/placeholdername/components/component_b/component_a.py, src/lightning/app/cli/app-template/requirements.txt, src/lightning/app/cli/app-template/setup.py, src/lightning/app/cli/app-template/tests/__init__.py, src/lightning/app/cli/app-template/tests/requirements.txt, src/lightning/app/cli/app-template/tests/test_placeholdername_app.py, src/lightning/app/cli/cmd_apps.py, src/lightning/app/cli/cmd_init.py, src/lightning/app/cli/cmd_install.py, src/lightning/app/cli/cmd_pl_init.py, src/lightning/app/cli/cmd_react_ui_init.py, src/lightning/app/cli/commands/__init__.py, src/lightning/app/cli/commands/app_commands.py, src/lightning/app/cli/commands/cd.py, src/lightning/app/cli/commands/cp.py, src/lightning/app/cli/commands/logs.py, src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/commands/pwd.py, src/lightning/app/cli/commands/rm.py, src/lightning/app/cli/component-template/LICENSE, src/lightning/app/cli/component-template/app.py, src/lightning/app/cli/component-template/placeholdername/__init__.py, src/lightning/app/cli/component-template/placeholdername/component.py, src/lightning/app/cli/component-template/requirements.txt, src/lightning/app/cli/component-template/setup.py, src/lightning/app/cli/component-template/tests/__init__.py, src/lightning/app/cli/component-template/tests/requirements.txt, src/lightning/app/cli/component-template/tests/test_placeholdername_component.py, src/lightning/app/cli/connect/__init__.py, src/lightning/app/cli/connect/app.py, src/lightning/app/cli/connect/data.py, src/lightning/app/cli/core.py, src/lightning/app/cli/lightning_cli.py, src/lightning/app/cli/lightning_cli_delete.py, src/lightning/app/cli/lightning_cli_launch.py, src/lightning/app/cli/lightning_cli_list.py, src/lightning/app/cli/pl-app-template/app.py, src/lightning/app/cli/pl-app-template/core/__init__.py, src/lightning/app/cli/pl-app-template/core/callbacks.py, src/lightning/app/cli/pl-app-template/core/components/__init__.py, src/lightning/app/cli/pl-app-template/core/components/logger/__init__.py, src/lightning/app/cli/pl-app-template/core/components/logger/tensorboard.py, src/lightning/app/cli/pl-app-template/core/components/logger/weights_and_biases.py, src/lightning/app/cli/pl-app-template/core/components/script_runner/__init__.py, src/lightning/app/cli/pl-app-template/core/components/script_runner/script_runner.py, src/lightning/app/cli/pl-app-template/core/state.py, src/lightning/app/cli/pl-app-template/setup.py, src/lightning/app/cli/pl-app-template/tests/__init__.py, src/lightning/app/cli/pl-app-template/tests/core/__init__.py, src/lightning/app/cli/pl-app-template/tests/core/test_callbacks.py, src/lightning/app/cli/pl-app-template/tests/test_app.py, src/lightning/app/cli/pl-app-template/ui/craco.config.js, src/lightning/app/cli/pl-app-template/ui/package.json, src/lightning/app/cli/pl-app-template/ui/public/favicon.svg, src/lightning/app/cli/pl-app-template/ui/public/index.html, src/lightning/app/cli/pl-app-template/ui/public/manifest.json, src/lightning/app/cli/pl-app-template/ui/public/robots.txt, src/lightning/app/cli/pl-app-template/ui/src/App.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/EnvironmentConfigurator.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/ErrorPanel.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/ExecutionSummary.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/HyperparameterSummary.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/Launcher.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/ProgressBar.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/ProgressBarGroup.tsx, src/lightning/app/cli/pl-app-template/ui/src/components/Timer.tsx, src/lightning/app/cli/pl-app-template/ui/src/hooks/useLightningState.ts, src/lightning/app/cli/pl-app-template/ui/src/index.css, src/lightning/app/cli/pl-app-template/ui/src/index.tsx, src/lightning/app/cli/pl-app-template/ui/src/lightning-colors.ts, src/lightning/app/cli/pl-app-template/ui/src/react-app-env.d.ts, src/lightning/app/cli/pl-app-template/ui/src/reportWebVitals.ts, src/lightning/app/cli/pl-app-template/ui/src/types/lightning.ts, src/lightning/app/cli/pl-app-template/ui/tsconfig.json, src/lightning/app/cli/react-ui-template/example_app.py, src/lightning/app/cli/react-ui-template/ui/index.html, src/lightning/app/cli/react-ui-template/ui/package.json, src/lightning/app/cli/react-ui-template/ui/src/App.css, src/lightning/app/cli/react-ui-template/ui/src/App.tsx, src/lightning/app/cli/react-ui-template/ui/src/favicon.svg, src/lightning/app/cli/react-ui-template/ui/src/hooks/useLightningState.ts, src/lightning/app/cli/react-ui-template/ui/src/index.css, src/lightning/app/cli/react-ui-template/ui/src/main.tsx, src/lightning/app/cli/react-ui-template/ui/src/types/lightning.ts, src/lightning/app/cli/react-ui-template/ui/src/vite-env.d.ts, src/lightning/app/cli/react-ui-template/ui/tsconfig.json, src/lightning/app/cli/react-ui-template/ui/tsconfig.node.json, src/lightning/app/cli/react-ui-template/ui/vite.config.ts, src/lightning/app/cli/react-ui-template/ui/yarn.lock, src/lightning/app/components/__init__.py, src/lightning/app/components/database/__init__.py, src/lightning/app/components/database/client.py, src/lightning/app/components/database/server.py, src/lightning/app/components/database/utilities.py, src/lightning/app/components/multi_node/__init__.py, src/lightning/app/components/multi_node/base.py, src/lightning/app/components/multi_node/fabric.py, src/lightning/app/components/multi_node/pytorch_spawn.py, src/lightning/app/components/multi_node/trainer.py, src/lightning/app/components/python/__init__.py, src/lightning/app/components/python/popen.py, src/lightning/app/components/python/tracer.py, src/lightning/app/components/serve/__init__.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/catimage.png, src/lightning/app/components/serve/cold_start_proxy.py, src/lightning/app/components/serve/gradio_server.py, src/lightning/app/components/serve/python_server.py, src/lightning/app/components/serve/serve.py, src/lightning/app/components/serve/streamlit.py, src/lightning/app/components/serve/types/__init__.py, src/lightning/app/components/serve/types/image.py, src/lightning/app/components/serve/types/type.py, src/lightning/app/components/training.py, src/lightning/app/core/__init__.py, src/lightning/app/core/api.py, src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/core/flow.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/frontend/__init__.py, src/lightning/app/frontend/frontend.py, src/lightning/app/frontend/just_py/__init__.py, src/lightning/app/frontend/just_py/just_py.py, src/lightning/app/frontend/just_py/just_py_base.py, src/lightning/app/frontend/panel/__init__.py, src/lightning/app/frontend/panel/app_state_comm.py, src/lightning/app/frontend/panel/app_state_watcher.py, src/lightning/app/frontend/panel/panel_frontend.py, src/lightning/app/frontend/panel/panel_serve_render_fn.py, src/lightning/app/frontend/stream_lit.py, src/lightning/app/frontend/streamlit_base.py, src/lightning/app/frontend/utils.py, src/lightning/app/frontend/web.py, src/lightning/app/launcher/__init__.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/launcher/lightning_hybrid_backend.py, src/lightning/app/launcher/utils.py, src/lightning/app/pdb/__init__.py, src/lightning/app/pdb/pdb.py, src/lightning/app/plugin/__init__.py, src/lightning/app/plugin/plugin.py, src/lightning/app/runners/__init__.py, src/lightning/app/runners/backends/__init__.py, src/lightning/app/runners/backends/backend.py, src/lightning/app/runners/backends/cloud.py, src/lightning/app/runners/backends/docker.py, src/lightning/app/runners/backends/mp_process.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/multiprocess.py, src/lightning/app/runners/runtime.py, src/lightning/app/runners/runtime_type.py, src/lightning/app/source_code/__init__.py, src/lightning/app/source_code/copytree.py, src/lightning/app/source_code/hashing.py, src/lightning/app/source_code/local.py, src/lightning/app/source_code/tar.py, src/lightning/app/source_code/uploader.py, src/lightning/app/storage/__init__.py, src/lightning/app/storage/copier.py, src/lightning/app/storage/drive.py, src/lightning/app/storage/filesystem.py, src/lightning/app/storage/mount.py, src/lightning/app/storage/orchestrator.py, src/lightning/app/storage/path.py, src/lightning/app/storage/payload.py, src/lightning/app/storage/requests.py, src/lightning/app/structures/__init__.py, src/lightning/app/structures/dict.py, src/lightning/app/structures/list.py, src/lightning/app/testing/__init__.py, src/lightning/app/testing/config.py, src/lightning/app/testing/helpers.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/__init__.py, src/lightning/app/utilities/app_commands.py, src/lightning/app/utilities/app_helpers.py, src/lightning/app/utilities/app_logs.py, src/lightning/app/utilities/app_status.py, src/lightning/app/utilities/auth.py, src/lightning/app/utilities/cli_helpers.py, src/lightning/app/utilities/cloud.py, src/lightning/app/utilities/clusters.py, src/lightning/app/utilities/commands/__init__.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/component.py, src/lightning/app/utilities/data_structures.py, src/lightning/app/utilities/dependency_caching.py, src/lightning/app/utilities/enum.py, src/lightning/app/utilities/exceptions.py, src/lightning/app/utilities/frontend.py, src/lightning/app/utilities/git.py, src/lightning/app/utilities/imports.py, src/lightning/app/utilities/introspection.py, src/lightning/app/utilities/layout.py, src/lightning/app/utilities/load_app.py, src/lightning/app/utilities/log.py, src/lightning/app/utilities/log_helpers.py, src/lightning/app/utilities/login.py, src/lightning/app/utilities/logs_socket_api.py, src/lightning/app/utilities/name_generator.py, src/lightning/app/utilities/network.py, src/lightning/app/utilities/openapi.py, src/lightning/app/utilities/packaging/__init__.py, src/lightning/app/utilities/packaging/app_config.py, src/lightning/app/utilities/packaging/build_config.py, src/lightning/app/utilities/packaging/cloud_compute.py, src/lightning/app/utilities/packaging/docker.py, src/lightning/app/utilities/packaging/lightning_utils.py, src/lightning/app/utilities/packaging/tarfile.py, src/lightning/app/utilities/port.py, src/lightning/app/utilities/proxies.py, src/lightning/app/utilities/redis.py, src/lightning/app/utilities/safe_pickle.py, src/lightning/app/utilities/scheduler.py, src/lightning/app/utilities/secrets.py, src/lightning/app/utilities/state.py, src/lightning/app/utilities/tracer.py, src/lightning/app/utilities/tree.py, src/lightning/app/utilities/types.py, src/lightning/app/utilities/warnings.py, src/lightning/fabric/cli.py, src/lightning/store/__init__.py, src/lightning/store/store.py, src/lightning/store/utils.py, src/lightning_app/MANIFEST.in, src/lightning_app/__about__.py, src/lightning_app/__main__.py, src/lightning_app/__setup__.py, src/lightning_app/__version__.py, src/lightning_app/py.typed, src/lightning_app/shell-folder_code-lives-lightning.info, requirements/app/app.txt, requirements/app/cloud.txt, requirements/app/components.txt, requirements/app/test.txt, requirements/app/ui.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90%. Comparing base (37e04d0) to head (cd6cb9e).
Report is 74 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20039      +/-   ##
==========================================
+ Coverage      83%      90%      +7%     
==========================================
  Files         427      266     -161     
  Lines       35460    22939   -12521     
==========================================
- Hits        29599    20720    -8879     
+ Misses       5861     2219    -3642     

@github-actions github-actions bot added the store label Jul 4, 2024
@mergify mergify bot added the ready PRs ready to be merged label Jul 5, 2024
@lantiga lantiga merged commit 330af38 into master Jul 5, 2024
117 of 119 checks passed
@lantiga lantiga deleted the removal/lightning-app branch July 5, 2024 11:56
awaelchli added a commit that referenced this pull request Jul 5, 2024
lantiga pushed a commit that referenced this pull request Jul 8, 2024
weiji14 added a commit to regro-cf-autotick-bot/lightning-feedstock that referenced this pull request Jul 14, 2024
weiji14 added a commit to conda-forge/lightning-feedstock that referenced this pull request Jul 14, 2024
* updated v2.3.3

* Remove lightning-app licenses

Xref Lightning-AI/pytorch-lightning#20039

---------

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ci Continuous Integration dependencies Pull requests that update a dependency file docs Documentation related fabric lightning.fabric.Fabric package pl Generic label for PyTorch Lightning package ready PRs ready to be merged store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants