-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize argument-free object params before logging #19771
Conversation
…arams in test case, just like in the actual code
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19771 +/- ##
=========================================
- Coverage 84% 59% -25%
=========================================
Files 426 421 -5
Lines 35280 35185 -95
=========================================
- Hits 29616 20775 -8841
- Misses 5664 14410 +8746 |
@awaelchli could you have a look at this PR? It's been open and ready for a while now and it is quite a simple change. Let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @V0XNIHILI
Thanks for sending the fix.
I pushed minor changes (the test wasn't passing because you asserted the repr, but the repr would only apply to an instance anyway).
What does this PR do?
This PR sanitizes object params before they get logged to WandB and Neptune.
Fixes #19772
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
I had fun coding :D
📚 Documentation preview 📚: https://pytorch-lightning--19771.org.readthedocs.build/en/19771/