Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support peft package for loading lora-adapted models #19546

Closed
wants to merge 2 commits into from

Conversation

moghadas76
Copy link
Contributor

@moghadas76 moghadas76 commented Feb 28, 2024

What does this PR do?

Support peft package for lora-based finetuning to be consistent with Huggin face

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19546.org.readthedocs.build/en/19546/

@github-actions github-actions bot added app (removed) Generic label for Lightning App package pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Feb 28, 2024
@moghadas76
Copy link
Contributor Author

@awaelchli
Copy link
Contributor

Hey @moghadas76

Thanks for opening a PR. These changes don't fit very well into Lightning, because Lightning doesn't make assumptions about the model architecture and composition and so a custom loading logic like this is very likely not in scope. Would you mind opening an issue with a description of how you'd like to do peft finetuning in Lightning? I'm sure we can find a way to make this possible in your LightningModule without needing to change the core saving and loading logic.

@awaelchli awaelchli closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package dependencies Pull requests that update a dependency file pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants