-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible and easy to use HSDP setting #19504
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19504 +/- ##
=========================================
- Coverage 84% 59% -25%
=========================================
Files 426 421 -5
Lines 35264 35182 -82
=========================================
- Hits 29553 20772 -8781
- Misses 5711 14410 +8699 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. Looking forward to this feature.
for more information, see https://pre-commit.ci
Any updates on this? |
Hi @awaelchli , I just fixed a merge conflict with the master and pushed the change. Could you take another look? Let me know if you have any concerns. |
All checks have passed. But I don't have access to merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Liyang90 Thank you for contributing this, and apologies for the delay.
I allowed myself to push a minor change regarding the import and extending the test.
What does this PR do?
Fixes #19502
It allows users to provide
device_mesh
as a tuple to theFSDPStrategy
.The test case for hybrid fsdp strategy would be broken, because_init_sharding_strategy
is moved out of the__init__
function.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19504.org.readthedocs.build/en/19504/