Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix link to colossalai #19263

Merged
merged 1 commit into from
Jan 10, 2024
Merged

docs: fix link to colossalai #19263

merged 1 commit into from
Jan 10, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 10, 2024

What does this PR do?

after removal in #19248

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @tchaton

@Borda Borda added the priority: 1 Medium priority task label Jan 10, 2024
@github-actions github-actions bot added docs Documentation related pl Generic label for PyTorch Lightning package and removed priority: 1 Medium priority task labels Jan 10, 2024
@Borda Borda added this to the 2.1.x milestone Jan 10, 2024
Copy link
Contributor

github-actions bot commented Jan 10, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to docs/source-pytorch/upgrade/sections/1_9_advanced.rst.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@carmocca carmocca merged commit 79b082a into master Jan 10, 2024
25 checks passed
@carmocca carmocca deleted the docs/link branch January 10, 2024 17:11
@mergify mergify bot added the ready PRs ready to be merged label Jan 10, 2024
awaelchli pushed a commit that referenced this pull request Jan 30, 2024
lexierule pushed a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants