Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 22, 2023

What does this PR do?

#19191 didn't run the full CI suite, for some inexplicable reason. It was merged without us noticing that the test never ran. What an epic fail?

In this PR, I simply fix the remaining tests that should have been updated in #19191.


📚 Documentation preview 📚: https://pytorch-lightning--19205.org.readthedocs.build/en/19205/

cc @Borda @carmocca @awaelchli

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.12, oldest) success
pl-cpu (macOS-11, lightning, 3.9, 1.12) success
pl-cpu (macOS-11, lightning, 3.10, 1.13) success
pl-cpu (macOS-11, lightning, 3.10, 2.0) success
pl-cpu (macOS-11, lightning, 3.10, 2.1) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.12, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
pl-cpu (windows-2022, lightning, 3.8, 1.12, oldest) success
pl-cpu (windows-2022, lightning, 3.9, 1.12) success
pl-cpu (windows-2022, lightning, 3.10, 1.13) success
pl-cpu (windows-2022, lightning, 3.10, 2.0) success
pl-cpu (windows-2022, lightning, 3.10, 2.1) success
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success
pl-cpu (macOS-12, pytorch, 3.11, 2.0) success
pl-cpu (macOS-12, pytorch, 3.11, 2.1) success
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0) success
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1) success
pl-cpu (windows-2022, pytorch, 3.11, 2.0) success
pl-cpu (windows-2022, pytorch, 3.11, 2.1) success

These checks are required after the changes to tests/tests_pytorch/checkpointing/test_checkpoint_callback_frequency.py, tests/tests_pytorch/models/test_restore.py, tests/tests_pytorch/plugins/test_checkpoint_io_plugin.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to tests/tests_pytorch/checkpointing/test_checkpoint_callback_frequency.py, tests/tests_pytorch/models/test_restore.py, tests/tests_pytorch/plugins/test_checkpoint_io_plugin.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@awaelchli awaelchli changed the title [WIP] Run CI Fix ModelCheckpoint tests from incomplete PR Dec 22, 2023
@awaelchli awaelchli added this to the 2.2 milestone Dec 22, 2023
@codecov
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Merging #19205 (05d78ab) into master (6ea0e2d) will decrease coverage by 22%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #19205     +/-   ##
=========================================
- Coverage      72%      49%    -22%     
=========================================
  Files         445      437      -8     
  Lines       37307    37154    -153     
=========================================
- Hits        26708    18247   -8461     
- Misses      10599    18907   +8308     

@mergify mergify bot added the ready PRs ready to be merged label Dec 22, 2023
@Borda Borda merged commit 8588032 into master Dec 22, 2023
@Borda Borda deleted the tests/github-wtf branch December 22, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

callback: model checkpoint pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants