Sort column headers for csv logger #19159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishb00
requested review from
awaelchli,
carmocca,
justusschock and
Borda
as code owners
github-actions
bot
added
fabric
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19159 +/- ##
==========================================
- Coverage 83% 54% -29%
==========================================
Files 443 438 -5
Lines 36865 36768 -97
==========================================
- Hits 30719 19924 -10795
- Misses 6146 16844 +10698 |
awaelchli
reviewed
Dec 16, 2023
awaelchli
added
feature
awaelchli
changed the title
awaelchli
changed the title
harishb00
commented
Dec 17, 2023
harishb00
force-pushed
the
bugfix/18978_csvlogorder
branch
from
7aedb10
to
1e1fe43
Compare
for more information, see https://pre-commit.ci
awaelchli
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the issue (#18978 ) where every time a csv log is written, the column headers are of random order. The fix is sorting the column headers. A new testcase is added to test the implementation.
Files affected
src/lightning/fabric/loggers/csv_logs.pytests/tests_pytorch/loggers/test_csv.py📚 Documentation preview 📚: https://pytorch-lightning--19159.org.readthedocs.build/en/19159/