ci/tests: cleaning standalone script #19141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fabric
Borda
changed the title
Borda
requested review from
awaelchli,
carmocca,
justusschock,
williamFalcon,
ethanwharris,
lantiga and
tchaton
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19141 +/- ##
=========================================
- Coverage 81% 66% -16%
=========================================
Files 443 438 -5
Lines 36760 36662 -98
=========================================
- Hits 29854 24084 -5770
- Misses 6906 12578 +5672 |
Borda
commented
Dec 12, 2023
| echo "Running profilers/test_profiler.py::test_pytorch_profiler_nested_emit_nvtx" | ||
| nvprof --profile-from-start off -o trace_name.prof -- python -m coverage run --source lightning.pytorch --append -m pytest --no-header profilers/test_profiler.py::test_pytorch_profiler_nested_emit_nvtx | ||
| fi | ||
| #can_run_nvprof=$(python -c "import torch; print(torch.cuda.is_available() and torch.cuda.get_device_capability()[0] < 8)") |
There was a problem hiding this comment.
note this was not run in any our CI
Borda
commented
Dec 12, 2023
Borda
commented
Dec 12, 2023
Borda
commented
Dec 12, 2023
Borda
commented
Dec 12, 2023
Borda
changed the title
Borda
changed the title
ethanwharris
approved these changes
Dec 13, 2023
Merged
Borda
added a commit
that referenced
this pull request
Dec 19, 2023
* tests: cleaning standalone script * switch * from tests * -m * collect * array * tests_fabric/ * .. * path prefix * pl * cleaning * test_pytorch_profiler_nested_emit_nvtx * Apply suggestions from code review * Apply suggestions from code review * todo (cherry picked from commit 2a8789e)
lantiga
pushed a commit
that referenced
this pull request
Dec 20, 2023
* tests: cleaning standalone script * switch * from tests * -m * collect * array * tests_fabric/ * .. * path prefix * pl * cleaning * test_pytorch_profiler_nested_emit_nvtx * Apply suggestions from code review * Apply suggestions from code review * todo (cherry picked from commit 2a8789e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
simplify & unify standalone scripts for maintenance
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19141.org.readthedocs.build/en/19141/
cc @carmocca @Borda @justusschock @awaelchli