[TPU] Rename classes to use XLA instead of TPU #17383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fabric
Borda
reviewed
Apr 14, 2023
carmocca
changed the title
SingleTPUStrategy
carmocca
force-pushed
the
carmocca/single-tpu-strategy-rename
branch
from
48e767b
to
b3a43b6
Compare
carmocca
requested review from
awaelchli,
justusschock,
williamFalcon and
edenlightning
as code owners
carmocca
commented
Apr 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #17383 +/- ##
=========================================
- Coverage 70% 62% -8%
=========================================
Files 416 412 -4
Lines 31524 31523 -1
=========================================
- Hits 21910 19541 -2369
- Misses 9614 11982 +2368 |
for more information, see https://pre-commit.ci
Borda
approved these changes
Apr 27, 2023
awaelchli
approved these changes
Apr 28, 2023
mergify
bot
added
ready
mergify
bot
added
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #16130
Not only TPUs can be XLA devices (see #16130)
This PR renames:
SingleTPUStrategytoSingleDeviceXLAStrategy(rhyme withXLAStrategy)TPUAcceleratortoXLAAcceleratorTPUPrecisionPlugintoXLAPrecisionPluginTPUPrecisiontoXLAPrecisionTPUBf16PrecisionPlugintoXLABf16PrecisionPluginTPUBf16PrecisiontoXLABf16PrecisionThe deprecation is done through the graveyard. There's no removal version for the deprecations.
Please note that the XLA strategies are marked as experimental.
Still, there should be no breaking changes
cc @Borda @justusschock @awaelchli @tchaton @carmocca @JackCaoG @steventk-g @Liyang90