Skip to content

readability deepspeed condition #17232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2023
Merged

readability deepspeed condition #17232

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc42959
ensure deepspeed condition
Borda Mar 30, 2023
c84c89c
Merge branch 'master' into check/deepspeed
Borda Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/lightning/fabric/strategies/deepspeed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,13 @@
_DEEPSPEED_AVAILABLE = (
# DeepSpeed fails under 0.8.2 with torch 2.0: https://github.com/microsoft/DeepSpeed/pull/2863
RequirementCache("deepspeed>=0.8.2")
or not _TORCH_GREATER_EQUAL_2_0
# check packaging because of https://github.com/microsoft/DeepSpeed/pull/2771
# remove the packaging check when min version is >=0.8.1
and RequirementCache("deepspeed")
and RequirementCache("packaging>=20.0")
or (
not _TORCH_GREATER_EQUAL_2_0
and RequirementCache("deepspeed")
# check packaging because of https://github.com/microsoft/DeepSpeed/pull/2771
# remove the packaging check when min version is >=0.8.1
and RequirementCache("packaging>=20.0")
)
)
if TYPE_CHECKING and _DEEPSPEED_AVAILABLE:
import deepspeed
Expand Down