Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data docs #16839

Merged
merged 4 commits into from
Mar 14, 2023
Merged

Update data docs #16839

merged 4 commits into from
Mar 14, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 22, 2023 •
edited by github-actions bot
Loading

What does this PR do?

Follow-up to #16726

cc @Borda @justusschock @awaelchli

@carmocca carmocca added docs Documentation related data handling Generic data-related topic labels Feb 22, 2023
@carmocca carmocca added this to the 2.0 milestone Feb 22, 2023
@carmocca carmocca self-assigned this Feb 22, 2023
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 22, 2023
@carmocca carmocca mentioned this pull request Feb 22, 2023
Merged
10 tasks
@carmocca carmocca force-pushed the docs/data-handling branch 2 times, most recently from 9f49a85 to c58adc1 Compare March 2, 2023 17:59
@carmocca carmocca changed the title Update data handling docs Update data docs Mar 10, 2023
@carmocca carmocca force-pushed the docs/data-handling branch 2 times, most recently from 75a2ac6 to 8da25f5 Compare March 13, 2023 14:58
This was referenced Mar 13, 2023
Merged
Merged
@carmocca carmocca marked this pull request as ready for review March 13, 2023 15:19
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to docs/source-pytorch/advanced/speed.rst, docs/source-pytorch/data/access.rst, docs/source-pytorch/data/alternatives.rst, docs/source-pytorch/data/data.rst, docs/source-pytorch/data/datamodule.rst, docs/source-pytorch/data/iterables.rst, docs/source-pytorch/guides/data.rst, docs/source-pytorch/index.rst.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

awaelchli
awaelchli approved these changes Mar 13, 2023
View reviewed changes
docs/source-pytorch/data/data.rst Outdated Show resolved Hide resolved
docs/source-pytorch/data/alternatives.rst Show resolved Hide resolved
docs/source-pytorch/data/infinite.rst Outdated Show resolved Hide resolved
docs/source-pytorch/data/infinite.rst Outdated Show resolved Hide resolved
docs/source-pytorch/data/iterables.rst Show resolved Hide resolved
docs/source-pytorch/guides/data.rst Show resolved Hide resolved
justusschock
justusschock approved these changes Mar 14, 2023
View reviewed changes
docs/source-pytorch/data/access.rst Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Mar 14, 2023
@carmocca @justusschock
Update docs/source-pytorch/data/access.rst
270d0af 
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
@carmocca carmocca requested a review from awaelchli March 14, 2023 15:08
@carmocca carmocca enabled auto-merge (squash) March 14, 2023 16:09
lantiga
lantiga approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@carmocca carmocca merged commit 281efc6 into master Mar 14, 2023
@carmocca carmocca deleted the docs/data-handling branch March 14, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga lantiga approved these changes

@justusschock justusschock justusschock approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

Assignees

@carmocca carmocca

Labels
data handling Generic data-related topic docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@carmocca @lantiga @awaelchli @justusschock