Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move _TrainingEpochLoop #16801

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Move _TrainingEpochLoop #16801

merged 1 commit into from
Feb 20, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 17, 2023 •
edited by github-actions bot
Loading

What does this PR do?

Suggested by a reviewer in #16726 (comment)

cc @Borda @justusschock @awaelchli @carmocca

@carmocca carmocca added refactor loops Related to the Loop API pl Generic label for PyTorch Lightning package labels Feb 17, 2023
@carmocca carmocca added this to the 2.0 milestone Feb 17, 2023
@carmocca carmocca self-assigned this Feb 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.9, 1.12) success ✅
pl-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.9, 1.11) success ✅
pl-cpu (windows-2022, lightning, 3.10, 1.12) success ✅
pl-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success ✅

These checks are required after the changes to src/lightning/pytorch/loops/__init__.py, src/lightning/pytorch/loops/epoch/__init__.py, src/lightning/pytorch/loops/fit_loop.py, src/lightning/pytorch/loops/training_epoch_loop.py, tests/tests_pytorch/loops/epoch/__init__.py, tests/tests_pytorch/loops/test_training_epoch_loop.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to src/lightning/pytorch/loops/__init__.py, src/lightning/pytorch/loops/epoch/__init__.py, src/lightning/pytorch/loops/fit_loop.py, src/lightning/pytorch/loops/training_epoch_loop.py, tests/tests_pytorch/loops/epoch/__init__.py, tests/tests_pytorch/loops/test_training_epoch_loop.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to src/lightning/pytorch/loops/__init__.py, src/lightning/pytorch/loops/epoch/__init__.py, src/lightning/pytorch/loops/fit_loop.py, src/lightning/pytorch/loops/training_epoch_loop.py, tests/tests_pytorch/loops/epoch/__init__.py, tests/tests_pytorch/loops/test_training_epoch_loop.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to src/lightning/pytorch/loops/__init__.py, src/lightning/pytorch/loops/epoch/__init__.py, src/lightning/pytorch/loops/fit_loop.py, src/lightning/pytorch/loops/training_epoch_loop.py, tests/tests_pytorch/loops/epoch/__init__.py, tests/tests_pytorch/loops/test_training_epoch_loop.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to src/lightning/pytorch/loops/__init__.py, src/lightning/pytorch/loops/epoch/__init__.py, src/lightning/pytorch/loops/fit_loop.py, src/lightning/pytorch/loops/training_epoch_loop.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning/pytorch/loops/__init__.py, src/lightning/pytorch/loops/epoch/__init__.py, src/lightning/pytorch/loops/fit_loop.py, src/lightning/pytorch/loops/training_epoch_loop.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/lightning/pytorch/loops/__init__.py, src/lightning/pytorch/loops/epoch/__init__.py, src/lightning/pytorch/loops/fit_loop.py, src/lightning/pytorch/loops/training_epoch_loop.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@carmocca carmocca mentioned this pull request Feb 17, 2023
Merged
10 tasks
@carmocca carmocca merged commit 83b8899 into master Feb 20, 2023
@carmocca carmocca deleted the refactor/move-training-epoch-loop branch February 20, 2023 12:33
@mergify mergify bot added the ready PRs ready to be merged label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock justusschock approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
loops Related to the Loop API pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@carmocca @awaelchli @justusschock