Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sized iterable typing improvements #16585

Merged
merged 10 commits into from
Feb 1, 2023
Merged

Sized iterable typing improvements #16585

merged 10 commits into from
Feb 1, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 31, 2023 •
edited by github-actions bot
Loading

What does this PR do?

Part of #10696

Does your PR introduce any breaking changes? If yes, please list them.

None

cc @Borda @justusschock @awaelchli @carmocca

@carmocca carmocca added refactor data handling Generic data-related topic labels Jan 31, 2023
@carmocca carmocca added this to the 2.0 milestone Jan 31, 2023
@carmocca carmocca self-assigned this Jan 31, 2023
@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Jan 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.8, 1.10, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.8, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/data.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/tuner/batch_size_scaling.py, src/lightning/pytorch/utilities/data.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/tuner/batch_size_scaling.py, src/lightning/pytorch/utilities/data.py, src/lightning/fabric/utilities/data.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/data.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/tuner/batch_size_scaling.py, src/lightning/pytorch/utilities/data.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/data.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/tuner/batch_size_scaling.py, src/lightning/pytorch/utilities/data.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/tuner/batch_size_scaling.py, src/lightning/pytorch/utilities/data.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, fabric, 3.8, 1.11) success ✅
fabric-cpu (macOS-11, fabric, 3.9, 1.12) success ✅
fabric-cpu (macOS-11, fabric, 3.10, 1.13) success ✅
fabric-cpu (macOS-11, fabric, 3.8, 1.10, oldest) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 1.11) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.12) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.13) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10, oldest) success ✅
fabric-cpu (windows-2022, fabric, 3.9, 1.11) success ✅
fabric-cpu (windows-2022, fabric, 3.10, 1.12) success ✅
fabric-cpu (windows-2022, fabric, 3.10, 1.13) success ✅
fabric-cpu (windows-2022, fabric, 3.8, 1.10, oldest) success ✅
fabric-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/data.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/data.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning/fabric/utilities/data.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/tuner/batch_size_scaling.py, src/lightning/pytorch/utilities/data.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/lightning/fabric/utilities/data.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/tuner/batch_size_scaling.py, src/lightning/pytorch/utilities/data.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

justusschock
justusschock approved these changes Feb 1, 2023
View reviewed changes
src/lightning_fabric/utilities/data.py Outdated Show resolved Hide resolved
src/lightning_fabric/utilities/data.py Outdated Show resolved Hide resolved
@mergify mergify bot added the has conflicts label Feb 1, 2023
@mergify mergify bot removed the has conflicts label Feb 1, 2023
awaelchli
awaelchli approved these changes Feb 1, 2023
View reviewed changes
src/lightning_fabric/utilities/data.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Feb 1, 2023
@github-actions github-actions bot removed the fabric lightning.fabric.Fabric label Feb 1, 2023
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Feb 1, 2023
@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Feb 1, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Feb 1, 2023
@carmocca carmocca enabled auto-merge (squash) February 1, 2023 18:18
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Feb 1, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Feb 1, 2023
@carmocca carmocca merged commit c8367a2 into master Feb 1, 2023
@carmocca carmocca deleted the refactor/size-improvements branch February 1, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock justusschock approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees

@carmocca carmocca

Labels
data handling Generic data-related topic fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@carmocca @awaelchli @justusschock