Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy errors attributed to pytorch_lightning.core.datamodule #13693

Merged
merged 43 commits into from
Aug 26, 2022
Merged

Fix mypy errors attributed to pytorch_lightning.core.datamodule #13693

merged 43 commits into from
Aug 26, 2022

Conversation

jxtngx
Copy link
Contributor

@jxtngx jxtngx commented Jul 17, 2022 •
edited
Loading

What does this PR do?

Fix mypy errors attributed to pytorch_lightning.core.datamodule for issue #13445

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@akihironitta akihironitta added lightningdatamodule pl.LightningDataModule code quality community This PR is from the community labels Jul 17, 2022
@akihironitta akihironitta added this to the pl:1.7 milestone Jul 17, 2022
@jxtngx jxtngx mentioned this pull request Jul 17, 2022
Closed
52 tasks
@jxtngx
Copy link
Contributor Author

jxtngx commented Jul 17, 2022 •
edited
Loading

blocked by core.saving of #13445

@otaj otaj modified the milestones: pl:1.7, pl:1.8 Jul 22, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 23, 2022
@jxtngx jxtngx marked this pull request as ready for review July 28, 2022 17:35
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 22, 2022
@otaj otaj enabled auto-merge (squash) August 22, 2022 12:43
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 26, 2022
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts ready PRs ready to be merged labels Aug 26, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 26, 2022
@otaj otaj merged commit ed84d04 into Lightning-AI:master Aug 26, 2022
@carmocca carmocca mentioned this pull request Aug 26, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@carmocca carmocca carmocca approved these changes

@otaj otaj otaj approved these changes

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@awaelchli awaelchli Awaiting requested review from awaelchli

@ananthsub ananthsub Awaiting requested review from ananthsub

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@otaj otaj

Labels
code quality community This PR is from the community lightningdatamodule pl.LightningDataModule pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
7 participants
@jxtngx @rohitgr7 @Borda @otaj @carmocca @awaelchli @akihironitta