Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future 3/n: docs adjustment #13299

Merged
merged 8 commits into from
Jun 15, 2022
Merged

Future 3/n: docs adjustment #13299

merged 8 commits into from
Jun 15, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 14, 2022

What does this PR do?

Part of #13265

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7

@mergify mergify bot removed the has conflicts label Jun 15, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jun 15, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 15, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Jun 15, 2022
@mergify mergify bot added ready PRs ready to be merged and removed ready PRs ready to be merged labels Jun 15, 2022
@carmocca carmocca changed the title Future 4/n: docs adjustment Future 3/n: docs adjustment Jun 15, 2022
@lexierule lexierule merged commit b58577f into master Jun 15, 2022
@lexierule lexierule deleted the future/docs branch June 15, 2022 14:54
@Borda Borda modified the milestones: PL:1.7, future Jun 17, 2022
@carmocca carmocca modified the milestones: future, pl:1.7 Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants