Skip to content

Conversation

@ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Feb 7, 2022

What does this PR do?

Follow up to #11747 (comment)

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7 @akihironitta @carmocca

@ananthsub ananthsub changed the title Update module path for LightningDeprecation warning in setup.cfg Update module path for LightningDeprecationWarning in setup.cfg Feb 7, 2022
@ananthsub ananthsub changed the title Update module path for LightningDeprecation warning in setup.cfg Update module path for LightningDeprecationWarning in setup.cfg Feb 7, 2022
@ananthsub ananthsub added this to the 1.6 milestone Feb 7, 2022
@ananthsub ananthsub linked an issue Feb 7, 2022 that may be closed by this pull request
@ananthsub ananthsub added the ci Continuous Integration label Feb 7, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 7, 2022
@ananthsub ananthsub enabled auto-merge (squash) February 7, 2022 17:41
@ananthsub ananthsub disabled auto-merge February 7, 2022 17:41
@ananthsub ananthsub enabled auto-merge (squash) February 7, 2022 17:49
@ananthsub ananthsub added the priority: 0 High priority task label Feb 7, 2022
@ananthsub ananthsub merged commit 8d23f62 into master Feb 10, 2022
@ananthsub ananthsub deleted the ananthsub-patch-1 branch February 10, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Centralize location of rank_zero utility functions

5 participants