Repository navigation
Conversation
speediedan
requested review from
Borda,
SeanNaren,
awaelchli,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
tchaton and
williamFalcon
as code owners
February 1, 2022 19:55
speediedan
commented
Feb 1, 2022
12 tasks done
carmocca
reviewed
Feb 1, 2022
speediedan
force-pushed
the
feature/enable_additional_finetuning_modes
branch
2 times, most recently
from
February 3, 2022 00:54
bd19fd2 to
044a67b
Compare
…t,validate,test,predict}, deprecate Trainer.{validated,tested,predicted}_ckpt_path
…instead of private and minor refactor of finetuning_callback test
speediedan
force-pushed
the
feature/enable_additional_finetuning_modes
branch
from
February 3, 2022 01:06
044a67b to
4008b86
Compare
carmocca
approved these changes
Feb 3, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
ananthsub
reviewed
Feb 3, 2022
ananthsub
enabled auto-merge (squash)
February 3, 2022 19:11
awaelchli
approved these changes
Feb 5, 2022
auto-merge was automatically disabled
February 5, 2022 03:44
Head branch was pushed to by a user without write access
Contributor
|
Awesome, thanks! @speediedan picking up some speed! |
9 of 12 tasks
ckpt_path within context of fit()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR includes two minor changes that enable callbacks to restore checkpoints iteratively within the context of
Trainer.fit()and prepares a deprecation path for theTrainer.{validated,tested,predicted}_ckpt_pathattributes.BaseFinetuning.__apply_mapping_to_param_groupsto protected instead of privateTrainer.{validated,tested,predicted}_ckpt_pathand replaces it with the read-only propertyTrainer.ckpt_pathset when checkpoints are loaded viaTrainer.{fit,validate,test,predict}Fixes:
#10630
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Yes :)
Make sure you had fun coding 🙃