Skip to content

Allow access to ckpt_path within context of fit() - #11696

Merged
awaelchli merged 6 commits into
Lightning-AI:masterfrom
speediedan:feature/enable_additional_finetuning_modes
Feb 5, 2022
Merged

awaelchli merged 6 commits into
Lightning-AI:masterfrom
speediedan:feature/enable_additional_finetuning_modes

Conversation

@speediedan

@speediedan speediedan commented Feb 1, 2022 •

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR includes two minor changes that enable callbacks to restore checkpoints iteratively within the context of Trainer.fit() and prepares a deprecation path for the Trainer.{validated,tested,predicted}_ckpt_path attributes.

  1. Changes BaseFinetuning.__apply_mapping_to_param_groups to protected instead of private
  2. Deprecates Trainer.{validated,tested,predicted}_ckpt_path and replaces it with the read-only property Trainer.ckpt_path set when checkpoints are loaded via Trainer.{fit,validate,test,predict}

Fixes:
#10630

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yes :)
Make sure you had fun coding 🙃

Comment thread pytorch_lightning/trainer/trainer.py Outdated
Comment thread pytorch_lightning/trainer/trainer.py Outdated
@speediedan
speediedan force-pushed the feature/enable_additional_finetuning_modes branch 2 times, most recently from bd19fd2 to 044a67b Compare February 3, 2022 00:54
…t,validate,test,predict}, deprecate Trainer.{validated,tested,predicted}_ckpt_path
…instead of private and minor refactor of finetuning_callback test
@speediedan
speediedan force-pushed the feature/enable_additional_finetuning_modes branch from 044a67b to 4008b86 Compare February 3, 2022 01:06
@speediedan
speediedan requested a review from carmocca February 3, 2022 01:53

@carmocca carmocca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Comment thread tests/deprecated_api/test_remove_1-8.py Outdated
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

@ananthsub ananthsub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mergify mergify Bot added the ready to be merged PRs ready to be merged label Feb 3, 2022
@ananthsub ananthsub added the checkpointing Related to checkpointing label Feb 3, 2022
Comment thread CHANGELOG.md Outdated
@ananthsub ananthsub added the deprecation Includes a deprecation label Feb 3, 2022
@ananthsub
ananthsub enabled auto-merge (squash) February 3, 2022 19:11
Comment thread pytorch_lightning/trainer/trainer.py Outdated
@awaelchli awaelchli added this to the 1.6 milestone Feb 5, 2022
auto-merge was automatically disabled February 5, 2022 03:44

Head branch was pushed to by a user without write access

@awaelchli
awaelchli merged commit 3bc2407 into Lightning-AI:master Feb 5, 2022
@awaelchli

Copy link
Copy Markdown
Contributor

Awesome, thanks! @speediedan picking up some speed!

@speediedan
speediedan deleted the feature/enable_additional_finetuning_modes branch May 12, 2022 19:58
@Borda Borda mentioned this pull request Mar 9, 2023
9 of 12 tasks
@Borda Borda changed the title Allow access to ckpt_path within context of fit() Allow access to ckpt_path within context of fit() Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

checkpointing Related to checkpointing deprecation Includes a deprecation ready to be merged PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants