Skip to content

Set the state before saving "last" or "none" checkpoints #11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 2, 2022

Conversation

nithinraok
Copy link
Contributor

@nithinraok nithinraok commented Jan 14, 2022

Signed-off-by: nithinraok nithinrao.koluguri@gmail.com

What does this PR do?

Related to issue #11451

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
@nithinraok nithinraok changed the title one-resume-fix fix last model path name for deleting the previous last.ckpt file Jan 14, 2022
@awaelchli awaelchli added bug Something isn't working callback: model checkpoint labels Jan 16, 2022
@awaelchli awaelchli added this to the 1.5.x milestone Jan 16, 2022
Signed-off-by: nithinraok <nithinrao.koluguri@gmail.com>
@mergify mergify bot removed the has conflicts label Jan 26, 2022
@carmocca carmocca self-assigned this Jan 26, 2022
@carmocca carmocca changed the title fix last model path name for deleting the previous last.ckpt file Set the state before saving "last" or "none" checkpoints Jan 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 26, 2022
@carmocca carmocca merged commit b8d2c65 into Lightning-AI:master Feb 2, 2022
@carmocca carmocca mentioned this pull request Feb 8, 2022
12 tasks
carmocca added a commit that referenced this pull request Feb 8, 2022
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request Feb 9, 2022
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working callback: model checkpoint ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants