Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Strategy.optimizer_zero_grad #11246

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Dec 23, 2021

What does this PR do?

Remove Strategy.optimizer_zero_grad since no Strategy subclasses this hook, and we can just call the LM hook directly

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@daniellepintz daniellepintz changed the title Removed Strategy.optimizer_zero_grad Remove Strategy.optimizer_zero_grad Dec 23, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with the removal from Strategy.
The strategy can intercept the optimizer.step() so it should also be able to do that with the zero_grad() call imo.

@mergify mergify bot added the ready PRs ready to be merged label Jan 3, 2022
CHANGELOG.md Show resolved Hide resolved
@carmocca carmocca added this to the 1.6 milestone Jan 3, 2022
@carmocca carmocca merged commit b082715 into Lightning-AI:master Jan 3, 2022
@daniellepintz daniellepintz deleted the optimizer_zero_grad branch January 3, 2022 18:40
rohitgr7 pushed a commit that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants