Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uv no longer requires editable installs #1187

Merged
merged 4 commits into from
Apr 3, 2024
Merged

uv no longer requires editable installs #1187

merged 4 commits into from
Apr 3, 2024

Conversation

carmocca
Copy link
Contributor

Reacting to #952 (comment)

@carmocca carmocca self-assigned this Mar 25, 2024
@carmocca carmocca mentioned this pull request Mar 25, 2024
Merged
@carmocca
Copy link
Contributor Author

Blocked by #952 (comment)

@carmocca carmocca closed this Mar 25, 2024
@Andrei-Aksionov
Copy link
Collaborator

UV was recently updated, so the issue should be resolved (after --prerelease=allow is removed).
I reran CI workflows and despite the issue arising at the "Install minimal dependencies" all the tests passed 🤷‍♂️.

Additionally, since now UV seems to work a bit more stable, maybe we should also use it in the GPU workflow?

@carmocca
Copy link
Contributor Author

carmocca commented Apr 3, 2024

Additionally, since now UV seems to work a bit more stable, maybe we should also use it in the GPU workflow?

That would be very welcome Andrei

@carmocca carmocca reopened this Apr 3, 2024
@carmocca carmocca marked this pull request as ready for review April 3, 2024 13:53
@carmocca carmocca merged commit 72c42fc into main Apr 3, 2024
8 checks passed
@carmocca carmocca deleted the carmocca/no-editable-install branch April 3, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli Awaiting requested review from awaelchli

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees

@carmocca carmocca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carmocca @Andrei-Aksionov