Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _get_folder_size: Reduce Logs noise and switch to os.scandir #499

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Mar 6, 2025

What does this PR do?

Improves _get_folder_size by:

  • Switching to os.scandir for better performance.
  • Including temporary .bin files in size calc without logging.
  • Reducing log noise by skipping temp file warnings.

Fixes #492.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy self-assigned this Mar 6, 2025
@bhimrazy bhimrazy added the enhancement New feature or request label Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 79%. Comparing base (43937d4) to head (130058c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #499   +/-   ##
===================================
  Coverage    79%    79%           
===================================
  Files        38     38           
  Lines      5646   5654    +8     
===================================
+ Hits       4470   4477    +7     
- Misses     1176   1177    +1     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tchaton tchaton merged commit 26243ae into Lightning-AI:main Mar 6, 2025
29 checks passed
@bhimrazy bhimrazy deleted the fix/get-folder-size-and-logging branch March 7, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suddenly receiving messages that Chunk-[number]-[number].bin.[random-string] is not a valid chunk file.
2 participants