-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: segmentation fault error in streaming tokens #485
Conversation
Removing the following line does resolve the issue; however, it will prevent memory-mapped files (mmaps) from being properly closed. Ideally, this is not a good solution, as it may lead to resource leaks. litdata/src/litdata/streaming/item_loader.py Line 413 in f6660be
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
===================================
- Coverage 79% 79% -0%
===================================
Files 38 38
Lines 5620 5626 +6
===================================
- Hits 4458 4456 -2
- Misses 1162 1170 +8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @bhimrazy @deependujha :)
Before submitting
What does this PR do?
fix: segmentation fault error while streaming tokens
Fixes #454 and #459.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃