Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with config for MinIO #174

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

bhimrazy
Copy link
Collaborator

Adds Example to support with MinIO Configuration

Fixes #170.

Here is an example repo: https://github.com/bhimrazy/litdata-with-minio
to validate the configurations

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@5ff7ae4). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #174   +/-   ##
=====================================
  Coverage        ?    78%           
=====================================
  Files           ?     33           
  Lines           ?   4324           
  Branches        ?      0           
=====================================
  Hits            ?   3363           
  Misses          ?    961           
  Partials        ?      0           

@bhimrazy bhimrazy requested a review from tchaton June 17, 2024 09:42
Copy link
Collaborator

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@tchaton tchaton merged commit d5eff39 into Lightning-AI:main Jun 17, 2024
28 checks passed
@bhimrazy bhimrazy deleted the feat/config-for-minio branch June 17, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Example to support with MinIO Configuration
2 participants