Skip to content

Conversation

@deependujha
Copy link
Collaborator

@deependujha deependujha commented Jun 24, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

Why this is required?

There're some tests which are skipped if dependency is not found. This pr makes sure they get tested in CI.

Without this pr:

https://github.com/Lightning-AI/litData/actions/runs/15850793770/job/44683478247?pr=631#step:5:586
10 tests are skipped

After this pr:

https://github.com/Lightning-AI/litData/actions/runs/15855101854/job/44698284723?pr=634#step:5:583
5 tests are skipped (which are explicitly marked to be skipped)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83%. Comparing base (e0c6ffe) to head (3793245).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #634   +/-   ##
===================================
  Coverage    83%    83%           
===================================
  Files        43     43           
  Lines      6609   6609           
===================================
+ Hits       5492   5505   +13     
+ Misses     1117   1104   -13     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Borda Borda merged commit c23a6d3 into Lightning-AI:main Jun 24, 2025
35 checks passed
@deependujha deependujha deleted the fix/donot-skip-tests-on-ubuntu branch June 24, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants