-
Notifications
You must be signed in to change notification settings - Fork 65
Fix: resume issues with resuming in combined streaming dataset in dataloader #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tchaton
merged 8 commits into
Lightning-AI:main
from
bhimrazy:fix/combined-dataset-loading-states
Mar 11, 2025
Merged
Fix: resume issues with resuming in combined streaming dataset in dataloader #507
tchaton
merged 8 commits into
Lightning-AI:main
from
bhimrazy:fix/combined-dataset-loading-states
Mar 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
🤞🫣 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
===================================
Coverage 79% 79%
===================================
Files 39 39
Lines 5844 5848 +4
===================================
+ Hits 4591 4602 +11
+ Misses 1253 1246 -7 🚀 New features to boost your workflow:
|
6 tasks
tchaton
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
How does this PR impact the user?
Currently, users experience issues when attempting to resume a combined streaming dataset with the streaming dataloader, as saving and restoring checkpoints doesn’t work as expected. This PR addresses the root cause of the error, enabling successful checkpoint resuming of the dataloader, ensuring smoother and more reliable training workflows.
What does this PR do?
Fixes #331.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
A lot , actually! 🙃
The PR (#362) had been pending since last September, but now, the underlying issue has finally been resolved with #449.