Skip to content

Add s5cmd #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Add s5cmd #506

merged 1 commit into from
Mar 11, 2025

Conversation

tchaton
Copy link
Collaborator

@tchaton tchaton commented Mar 10, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (e0e5e05) to head (1cdc8db).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #506   +/-   ##
===================================
  Coverage    79%    79%           
===================================
  Files        38     38           
  Lines      5719   5719           
===================================
  Hits       4525   4525           
  Misses     1194   1194           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bhimrazy bhimrazy merged commit d93a94d into main Mar 11, 2025
29 checks passed
@bhimrazy bhimrazy deleted the add_s5cmd branch March 11, 2025 05:09
bhimrazy added a commit that referenced this pull request Mar 23, 2025
This reverts commit d93a94d.
bhimrazy added a commit that referenced this pull request Mar 23, 2025
…marks (#521)

* Revert "Add s5cmd (#506)"

This reverts commit d93a94d.

* pin: update test requirements to include transformers <4.50.0

* update benchmark for streaming speed (float32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants