Skip to content

Slighy faster speed #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 10, 2025
Merged

Slighy faster speed #503

merged 10 commits into from
Mar 10, 2025

Conversation

tchaton
Copy link
Collaborator

@tchaton tchaton commented Mar 9, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

Before:

prefetch_factor = 10~ python benchmark/stream_imagenet.py
Seed set to 42
Benchmarking using litdata version: 0.2.41
100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 5005/5005 [04:13<00:00, 19.76it/s]
For /teamspace/studios/this_studio/benchmark/stream_imagenet.py on 0, streamed over 1281167 samples in 253.43733644485474 or 5055.162747104145 images/sec.
100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 5005/5005 [03:55<00:00, 21.26it/s]
For /teamspace/studios/this_studio/benchmark/stream_imagenet.py on 1, streamed over 1281167 samples in 235.43075132369995 or 5441.799668172387 images/sec.
prefetch_factor = 2~ python benchmark/stream_imagenet.py
Seed set to 42
Benchmarking using litdata version: 0.2.41
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 5005/5005 [03:59<00:00, 20.86it/s]
For /teamspace/studios/this_studio/benchmark/stream_imagenet.py on 0, streamed over 1281167 samples in 240.06360864639282 or 5336.781303894049 images/sec.
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 5005/5005 [03:49<00:00, 21.83it/s]
For /teamspace/studios/this_studio/benchmark/stream_imagenet.py on 1, streamed over 1281167 samples in 229.28257656097412 or 5587.720627958314 images/sec.
Finished benchmarking.

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 62.22222% with 17 lines in your changes missing coverage. Please review.

Project coverage is 79%. Comparing base (a2533b2) to head (3d6080e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #503   +/-   ##
===================================
- Coverage    79%    79%   -0%     
===================================
  Files        38     38           
  Lines      5691   5719   +28     
===================================
+ Hits       4509   4525   +16     
- Misses     1182   1194   +12     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tchaton tchaton merged commit e0e5e05 into main Mar 10, 2025
29 checks passed
@tchaton tchaton deleted the slightly_incrase_speed branch March 10, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant