Skip to content

Expose optimize dns #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 6, 2025
Merged

Expose optimize dns #498

merged 8 commits into from
Mar 6, 2025

Conversation

tchaton
Copy link
Collaborator

@tchaton tchaton commented Mar 6, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Enable the user to disable the optimised dns in Studios.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (4f4b38b) to head (47871d2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #498   +/-   ##
===================================
  Coverage    79%    79%           
===================================
  Files        38     38           
  Lines      5646   5646           
===================================
  Hits       4470   4470           
  Misses     1176   1176           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bhimrazy bhimrazy merged commit 43937d4 into main Mar 6, 2025
29 checks passed
@bhimrazy bhimrazy deleted the expose_litdata_optimize_dns branch March 6, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants