Skip to content

[WIP] Feat/add fsspec back #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[WIP] Feat/add fsspec back #467

wants to merge 3 commits into from

Conversation

bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Feb 10, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This PR is an extension of #348 by @deependujha.
Initially, the PR was reverted due to some CI issues.

We will investigate those issues and resolve them in this PR.

TBD...

PR review

Not ready yet

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy added the enhancement New feature or request label Feb 10, 2025
@deependujha
Copy link
Collaborator

Hi @bhimrazy,

The codebase has changed significantly, especially with the addition of HFDownloader, making it quite complex to integrate the old changes properly.

To avoid confusion and ensure everything aligns with the latest updates, I’m closing this PR. A fresh PR would be a better approach. Otherwise, we will be required to copy all parquet support and HF support codes from main branch to this old branch.

Thanks, and sorry for the trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants