Skip to content

[WIP] Improve debugging of DDP hanging #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 24, 2025
Merged

[WIP] Improve debugging of DDP hanging #456

merged 10 commits into from
Jan 24, 2025

Conversation

tchaton
Copy link
Collaborator

@tchaton tchaton commented Jan 23, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 67.41573% with 29 lines in your changes missing coverage. Please review.

Project coverage is 78%. Comparing base (49020d0) to head (d40afa8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #456   +/-   ##
===================================
- Coverage    79%    78%   -0%     
===================================
  Files        35     36    +1     
  Lines      5138   5217   +79     
===================================
+ Hits       4036   4088   +52     
- Misses     1102   1129   +27     

@tchaton tchaton changed the title Improve debugging of DDP hanging [WIP] Improve debugging of DDP hanging Jan 23, 2025
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good idea having a debug option in the open. Let's see what comes out of it.

@tchaton tchaton merged commit ee77852 into main Jan 24, 2025
29 checks passed
@tchaton tchaton deleted the debug_help branch January 24, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants