Skip to content

Feat: add support for custom cache dir in Streaming Dataset #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 28, 2024
Merged

Feat: add support for custom cache dir in Streaming Dataset #399

merged 7 commits into from
Oct 28, 2024

Conversation

bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Oct 27, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #398.

  • Adds support for custom cache dir in Streaming Dataset

Usage

import litdata as ld

dataset = ld.StreamingDataset(input_dir = 's3://my-bucket/fast_data', cache_dir='local_cache_dir' ,shuffle=True, drop_last=True)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy added the enhancement New feature or request label Oct 27, 2024
@bhimrazy bhimrazy self-assigned this Oct 27, 2024
@bhimrazy bhimrazy requested a review from tchaton as a code owner October 27, 2024 17:18
@bhimrazy bhimrazy marked this pull request as draft October 27, 2024 17:18
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (62907b3) to head (20be9e1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #399   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        34     34           
  Lines      5042   5045    +3     
===================================
+ Hits       3948   3954    +6     
+ Misses     1094   1091    -3     

@bhimrazy bhimrazy marked this pull request as ready for review October 27, 2024 18:36
@bhimrazy bhimrazy changed the title [WIP] Feat: add support for custom cache dir Feat: add support for custom cache dir Oct 27, 2024
@bhimrazy bhimrazy changed the title Feat: add support for custom cache dir [WIP] Feat: add support for custom cache dir in Streaming Dataset Oct 27, 2024
@bhimrazy bhimrazy changed the title [WIP] Feat: add support for custom cache dir in Streaming Dataset Feat: add support for custom cache dir in Streaming Dataset Oct 27, 2024
@tchaton tchaton merged commit 32194cd into Lightning-AI:main Oct 28, 2024
36 checks passed
@bhimrazy bhimrazy deleted the feat/add-cache-dir branch October 28, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing Cache files leads to permanent DataLoader hang
2 participants