Skip to content

pass storage options to s5cmd #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 14, 2024
Merged

pass storage options to s5cmd #397

merged 8 commits into from
Oct 14, 2024

Conversation

bhimrazy
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #392.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy requested a review from tchaton as a code owner October 13, 2024 10:20
@bhimrazy bhimrazy self-assigned this Oct 13, 2024
@bhimrazy bhimrazy added the enhancement New feature or request label Oct 13, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (3f47b5e) to head (4f4a1cc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #397   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        34     34           
  Lines      5040   5044    +4     
===================================
+ Hits       3944   3948    +4     
  Misses     1096   1096           

Copy link
Collaborator

@deependujha deependujha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we write a mock test for this?

Should we have a test for it? What do you think!

@bhimrazy
Copy link
Collaborator Author

Can we write a mock test for this?

Should we have a test for it? What do you think!

yeah, it would be great to have one. I will look into it.

@bhimrazy bhimrazy requested a review from deependujha October 14, 2024 06:01
@deependujha deependujha merged commit 7264fce into Lightning-AI:main Oct 14, 2024
28 of 29 checks passed
@bhimrazy bhimrazy deleted the feat/custom-s3-conf-s5cmd branch October 14, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for Custom S3 Configuration in s5cmd
2 participants