-
Notifications
You must be signed in to change notification settings - Fork 67
pass storage options to s5cmd #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass storage options to s5cmd #397
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
===================================
Coverage 78% 78%
===================================
Files 34 34
Lines 5040 5044 +4
===================================
+ Hits 3944 3948 +4
Misses 1096 1096 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we write a mock test for this?
Should we have a test for it? What do you think!
yeah, it would be great to have one. I will look into it. |
Co-authored-by: Deependu Jha <deependujha21@gmail.com>
for more information, see https://pre-commit.ci
Before submitting
What does this PR do?
Fixes #392.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃