Skip to content

Conversation

@tchaton
Copy link
Collaborator

@tchaton tchaton commented Sep 3, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton requested a review from awaelchli as a code owner September 3, 2024 11:12
@tchaton tchaton merged commit 8382067 into main Sep 3, 2024
@tchaton tchaton deleted the tchaton-patch-1 branch September 3, 2024 11:12
@codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (8b2b130) to head (77a02f0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #359   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        34     34           
  Lines      5008   5008           
===================================
+ Hits       3922   3929    +7     
+ Misses     1086   1079    -7     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant