try enabling ruff in pre-commit #2142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, let's stay with black please. |
Why do you prefer to use black? Ruff is a drop-in replacement but faster. |
I'm all for material performance gains. But black vs. ruff saves a fraction of the 35 seconds all tests in precommit take, usually run in parallel to other stuff. It's just not worth changing. Things like #2077 and #1874 and if we can disable tests #2144 will be much more impactful. I'm sure there is no shortage of other opportunities. |
t-vi
approved these changes
May 28, 2025
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
crcrpar
force-pushed
the
try-enable-runn-in-pre-commit
branch
from
55deff1 to
8c08883
Compare
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
crcrpar
force-pushed
the
try-enable-runn-in-pre-commit
branch
from
f8e06fc to
aba23a7
Compare
for more information, see https://pre-commit.ci
Borda
reviewed
Jun 3, 2025
Comment on lines
+41
to
+47
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| rev: v0.11.11 | ||
| hooks: | ||
| - id: black | ||
| name: Black code | ||
| exclude: "examples" | ||
| - id: ruff-check | ||
| args: ["--fix"] | ||
| - id: ruff-format | ||
| types_or: [python, pyi] |
There was a problem hiding this comment.
'Let''s split the PR to adding Ruff as flake8 and formatting, so the change is easier to trace/review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enabling
ruffin pre-commit.Currently only black is used but
lightning-thunder/thunder/dynamo/utils.py
Line 850 in d0f6474
ruffif it's available.