Skip to content

ci: test with latest dependencies #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

ci: test with latest dependencies #2122

wants to merge 15 commits into from

Conversation

Borda
Copy link
Member

@Borda Borda commented May 22, 2025

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This addresses now user's scenario who install the package on blank environment

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested review from lantiga and t-vi as code owners May 22, 2025 14:10
@github-actions github-actions bot added the ci label May 22, 2025
@Borda Borda requested a review from mruberry as a code owner May 22, 2025 14:20
Borda added 2 commits May 22, 2025 16:25
bitsandbytes>=0.45.2,<0.45.5; sys_platform!='darwin'
@Borda
Copy link
Member Author

Borda commented May 22, 2025

just for mac

l = <thunder.core.interpreter.WrappedValue object at 0x152a77460>

    def populate_item_wrappers(l):
        ctx: InterpreterCompileCtx = get_interpretercompilectx()
        if not ctx._with_provenance_tracking:
            return
    
        assert isinstance(l, WrappedValue)
        # to do: generalize
        if wrapped_isinstance(l, (list, tuple)):
            if l.item_wrappers is None:
                l.item_wrappers = [None for _ in range(len(l.value))]
            assert isinstance(l.item_wrappers, list)
            assert len(l.value) == len(l.item_wrappers), f"{len(l.value)=} {len(l.item_wrappers)=}"
    
            for i, v in enumerate(l.value):
                if l.item_wrappers[i] is None:
                    wv = wrap_binary_subscr(v, l, i)
                    l.item_wrappers[i] = wv
            return
    
        if wrapped_isinstance(l, dict):
            assert isinstance(l.item_wrappers, dict)
>           for k, v in l.value.items():
E           RuntimeError: dictionary changed size during iteration

thunder/core/interpreter.py:361: RuntimeError

@t-vi, any insides what is happening?

@Borda
Copy link
Member Author

Borda commented May 22, 2025

also on GPU:
FAILED thunder/tests/test_torch_compile_executor.py::test_torch_compile_cat_rope_single_fusion - ValueError: cos must be three-dimensional, but shape is (8192, 128)

@@ -12,12 +12,13 @@ expecttest ==0.3.0 # for test_ddp.py
hypothesis ~=6.131.9 # for test_ddp.py
numpy
einops # for test_einops.py
litgpt==0.4.11 # for the model definition in tests and benchmarks
litgpt==0.5.0 # for the model definition in tests and benchmarks # todo: need update to latest
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the last passing without the need for a fixing code/tests

@Borda Borda mentioned this pull request May 23, 2025
@requiresCUDA
@pytest.mark.skipif(not BITSANDBYTES_AVAILABLE, reason="`bitsandbytes` is not available")
@pytest.mark.xfail(ValueError, reason="Likely Fabric issue with `bitsandbytes`") # ToDo - fixme in Thunder
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@pytest.mark.xfail(ValueError, reason="Likely Fabric issue with `bitsandbytes`") # ToDo - fixme in Thunder

@pytest.mark.skipif(not device_supports_bf16(torch.device("cuda")), reason="bf16 is not supported")
@pytest.mark.xfail(ValueError, reason="cos must be three-dimensional, but shape is (8192, 128)") # ToDo: fix
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@pytest.mark.xfail(ValueError, reason="cos must be three-dimensional, but shape is (8192, 128)") # ToDo: fix

@kiya00 kiya00 mentioned this pull request May 30, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant