-
Notifications
You must be signed in to change notification settings - Fork 96
ci: test with latest dependencies #2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bitsandbytes>=0.45.2,<0.45.5; sys_platform!='darwin'
just for mac
@t-vi, any insides what is happening? |
also on GPU: |
…/lightning-thunder into ci/test-with-latest
@@ -12,12 +12,13 @@ expecttest ==0.3.0 # for test_ddp.py | |||
hypothesis ~=6.131.9 # for test_ddp.py | |||
numpy | |||
einops # for test_einops.py | |||
litgpt==0.4.11 # for the model definition in tests and benchmarks | |||
litgpt==0.5.0 # for the model definition in tests and benchmarks # todo: need update to latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the last passing without the need for a fixing code/tests
@requiresCUDA | ||
@pytest.mark.skipif(not BITSANDBYTES_AVAILABLE, reason="`bitsandbytes` is not available") | ||
@pytest.mark.xfail(ValueError, reason="Likely Fabric issue with `bitsandbytes`") # ToDo - fixme in Thunder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pytest.mark.xfail(ValueError, reason="Likely Fabric issue with `bitsandbytes`") # ToDo - fixme in Thunder |
@pytest.mark.skipif(not device_supports_bf16(torch.device("cuda")), reason="bf16 is not supported") | ||
@pytest.mark.xfail(ValueError, reason="cos must be three-dimensional, but shape is (8192, 128)") # ToDo: fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pytest.mark.xfail(ValueError, reason="cos must be three-dimensional, but shape is (8192, 128)") # ToDo: fix |
Before submitting
What does this PR do?
This addresses now user's scenario who install the package on blank environment
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃