Add parity check of shape/dtype/device of runtime and trace #2069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crcrpar
changed the title
|
For all the currently failing cases, you could add xfail(strict=True) decorators, and that would allow merging the pull request as is. Any other pull request that fixes the problems would also include a change in tests to remove the xfails. It would make it clearer that the change is covered with tests. |
|
Just wanted to shout that I love that we'll be checking this. Thank you @crcrpar |
- shape - device - dtype are supposed to be identical. Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
for more information, see https://pre-commit.ci
crcrpar
force-pushed
the
check_consistency_of_compile_and_runtime
branch
from
90e24e1 to
00bba73
Compare
|
Exciting stuff! @IvanYashchuk @beverlylytle, would you like to review this? |
mruberry
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding a check of the consistency aforementioned in the title.
related:
ltorch.cumsumshould return an int64 TensorProxy when input tensor is int or bool anddtype=None#1952