[wip] #2052
Draft
[wip] #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After a pause to work on other issues, I will now focus on finishing this PR. |
beverlylytle
commented
Jun 3, 2025
| @@ -54,13 +55,36 @@ def _involves_viewed_args(bsym, viewed): | |||
| return any(isinstance(p, TensorProxy) and variableify(p) in viewed for p in bsym.flat_proxy_args) | |||
|
|
|||
|
|
|||
| def _add_output_to_setitem(trace: Trace) -> Trace: | |||
There was a problem hiding this comment.
setitem_ returns no output, and so there were dataflow issues around update_aliases being called on the input to setitem_ rather than the output of the subsymbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to the introduction of using
update_aliasesto support in-place operations, this PR aims to make this approach the default instead of the functionalization approach.