Skip to content

Use f.write(...) instead of print(..., file=f) #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use f.write(...) instead of print(..., file=f) #1831

wants to merge 1 commit into from

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Mar 4, 2025

What does this PR do?

code_str seems to be guaranteed to be a string at

lightning-thunder/thunder/dynamo/report.py

Line 470 in ff74bef

code_str = f"{code_str}\ntest_{self.graph_name}()"
, thus it'd be reasonable to use f.write instead.

@crcrpar crcrpar changed the title f.write(...) <- print(..., file=f) Use f.write(...) instead of print(..., file=f) May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@t-vi t-vi Awaiting requested review from t-vi t-vi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crcrpar