Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable isort #327

Merged
merged 11 commits into from
Oct 7, 2024
Merged

enable isort #327

merged 11 commits into from
Oct 7, 2024

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Oct 7, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Code quality: sorted imports are better to navigate.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya enabled auto-merge (squash) October 7, 2024 15:05
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96%. Comparing base (f41649f) to head (5bb7e1c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #327   +/-   ##
===================================
  Coverage    95%    96%           
===================================
  Files        22     22           
  Lines      1338   1347    +9     
===================================
+ Hits       1275   1289   +14     
+ Misses       63     58    -5     

@aniketmaurya aniketmaurya merged commit ed5b68e into main Oct 7, 2024
20 checks passed
@aniketmaurya aniketmaurya deleted the aniket/enable-isort branch October 7, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants