avoid client generation if already exist #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketmaurya
requested review from
lantiga,
ethanwharris and
Andrei-Aksionov
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
===================================
Coverage 95% 96%
===================================
Files 21 21
Lines 1344 1343 -1
===================================
+ Hits 1283 1285 +2
+ Misses 61 58 -3 |
lantiga
approved these changes
Oct 7, 2024
|
|
||
| # Replace the default port number with the user-specified port number | ||
| client_code = client_code.replace("{{PORT}}", str(port)) | ||
| if os.path.exists(dest_path): |
There was a problem hiding this comment.
But is it a correct behaviour?
If I changed the port I expect that the file should be regenerated with a new, correct one.
Or maybe I am missing something?
There was a problem hiding this comment.
if you already have a client.py that you updated based on your server (let's say image classification). You won't want LitServe to replace the file. The generate client is supposed to be static template that people can quickly edit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
avoid client generation if already exist. Caught by @bhimrazy #307 (comment)
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃