Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dockerize CLI test #318

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix dockerize CLI test #318

merged 1 commit into from
Oct 2, 2024

Conversation

aniketmaurya
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes failing test to unblock #317

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya added the bug Something isn't working label Oct 2, 2024
@aniketmaurya aniketmaurya self-assigned this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95%. Comparing base (92e19e5) to head (c67b447).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #318   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files        21     21           
  Lines      1323   1323           
===================================
  Hits       1259   1259           
  Misses       64     64           

@aniketmaurya aniketmaurya merged commit 86e00bc into main Oct 2, 2024
20 checks passed
@aniketmaurya aniketmaurya deleted the fix-dockerize-test branch October 2, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci / tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants