Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle exceptions for logger processing #287

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Sep 23, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

⚠️ How does this PR impact the user? ⚠️

Avoid stopping logger process dues to exception.


What does this PR do?

Avoid stopping logger process dues to exception.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95%. Comparing base (e740976) to head (b11954e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #287   +/-   ##
===================================
- Coverage    95%    95%   -0%     
===================================
  Files        19     19           
  Lines      1241   1244    +3     
===================================
+ Hits       1181   1182    +1     
- Misses       60     62    +2     

@aniketmaurya aniketmaurya enabled auto-merge (squash) September 23, 2024 13:39
@aniketmaurya aniketmaurya merged commit b9ecbdb into main Sep 23, 2024
20 checks passed
@aniketmaurya aniketmaurya deleted the aniket/add-logger-try branch September 23, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants