Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install uvloop with uvcorn #274

Merged
merged 1 commit into from
Sep 8, 2024
Merged

install uvloop with uvcorn #274

merged 1 commit into from
Sep 8, 2024

Conversation

aniketmaurya
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

⚠️ How does this PR impact the user? ⚠️

Avoid uvloop not installed warning by automatic installation on supported system.

GOOD:

"As a user, I need to serve models faster. This PR focuses on enabling speed gains by using GPUs"

BAD:

"This PR enables GPUs".
This is bad because the user problem is not clear... instead it just jumps to the solution without any context.

PRs without this will not be merged.


What does this PR do?

uvloop is a faster drop-in replacement of asyncio loop and we used it during all our benchmarks. It should be shipped along with the package on supported systems.

uvcorn[standard] installs uvloop.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95%. Comparing base (1e7140d) to head (5e62946).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #274   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files        14     14           
  Lines      1082   1082           
===================================
+ Hits       1023   1025    +2     
+ Misses       59     57    -2     

@aniketmaurya aniketmaurya merged commit f4e5694 into main Sep 8, 2024
20 checks passed
@aniketmaurya aniketmaurya deleted the aniket/uvloop-default-dep branch September 8, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants