Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Avoid
uvloop
not installed warning by automatic installation on supported system.GOOD:
"As a user, I need to serve models faster. This PR focuses on enabling speed gains by using GPUs"
BAD:
"This PR enables GPUs".
This is bad because the user problem is not clear... instead it just jumps to the solution without any context.
PRs without this will not be merged.
What does this PR do?
uvloop is a faster drop-in replacement of asyncio loop and we used it during all our benchmarks. It should be shipped along with the package on supported systems.
uvcorn[standard]
installs uvloop.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃