Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add litserve.connector tests #256

Merged
merged 5 commits into from
Aug 30, 2024
Merged

add litserve.connector tests #256

merged 5 commits into from
Aug 30, 2024

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Aug 30, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

⚠️ How does this PR impact the user? ⚠️

No direct impact! Increase the code coverage which improves robustness.


What does this PR do?

Improves the test coverage for litserve.connector

Before

image

After

TODO

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92%. Comparing base (f2f70ea) to head (2e7aae6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #256   +/-   ##
===================================
+ Coverage    92%    92%   +1%     
===================================
  Files        14     14           
  Lines      1082   1082           
===================================
+ Hits        992    999    +7     
+ Misses       90     83    -7     

@aniketmaurya aniketmaurya enabled auto-merge (squash) August 30, 2024 21:01
@williamFalcon williamFalcon merged commit 042cd08 into main Aug 30, 2024
20 checks passed
@williamFalcon williamFalcon deleted the aniket/test-connectors branch August 30, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants