Don't insert line breaks in long URLs - #59
Merged
Conversation
owbone
requested review from
ethanwharris,
justusschock and
tchaton
as code owners
May 26, 2026 12:03
owbone
enabled auto-merge (squash)
May 26, 2026 13:54
k223kim
approved these changes
May 26, 2026
justusschock
approved these changes
May 26, 2026
tchaton
approved these changes
May 26, 2026
owbone
marked this pull request as draft
May 26, 2026 15:03
auto-merge was automatically disabled
May 26, 2026 15:03
Pull request was converted to draft
owbone
marked this pull request as ready for review
May 26, 2026 15:03
owbone
enabled auto-merge (squash)
May 26, 2026 15:04
justusschock
disabled auto-merge
May 26, 2026 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default,
richautomatically wraps text according to the console width by inserting new lines. This applies to the URLs that we render, and doesn't account for the prefix that we add later, so the end result is that URLs longer than the terminal width are unclickable and look a bit broken, e.g.:Use
soft_wrap=Trueto leave the wrapping up to the terminal.