Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packaging workflow #27

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Add packaging workflow #27

merged 4 commits into from
Apr 12, 2024

Conversation

Moosems
Copy link
Contributor

@Moosems Moosems commented Apr 10, 2024

Fixes #25

@Moosems
Copy link
Contributor Author

Moosems commented Apr 10, 2024

You will need to create a secret key for it that allows it to create releases and copy the code from the repository with the name TOKEN

@saviorand
Copy link
Collaborator

@Moosems just pushed a commit to main that should fix the packaging issue you were having.
See a couple small edits below: basically I think we can just use the default GITHUB_TOKEN for the release job with write permissions, no need for a custom token. Tested this on a private copy of the main repo and it works.
Can you explain why the modular auth examples works for authenticating with modular? 😄 this is very surprising to me.
Otherwise, with these small changes should be good to merge

Co-authored-by: Valentin Erokhin <37780080+saviorand@users.noreply.github.com>
@Moosems
Copy link
Contributor Author

Moosems commented Apr 12, 2024

@saviorand I don't know why it works. Its how they did it in the Modular/mojo workflows and it just works so I chose not to question it

@saviorand
Copy link
Collaborator

I assume it uses some existing token. I could also pass my own token as an env variable

@saviorand saviorand merged commit f981dd4 into Lightbug-HQ:main Apr 12, 2024
@saviorand
Copy link
Collaborator

Thanks a lot for the contribution! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mojopkg GH action
2 participants