Open
Conversation
sheesania
reviewed
Aug 14, 2020
…nction to enable test. However, even though most of the business logic is being tested now, nht_i_RestWriteAttrValue (or public callers) still is not tested at all. It would be trivially easy to test with mocks/stubs, but is quite complex to test otherwise, and so I judged that it wasn't worth it to spend a lot of time writing a complete test right now when we might be implementing a test framework with mocks/stubs relatively soon. Please, future me, save us from the screaming void.
…jdrv_sybase logic
…ll fixes to make test clearer
gbeeley
reviewed
Feb 11, 2022
Member
gbeeley
left a comment
gbeeley
left a comment
There was a problem hiding this comment.
I've finished looking over the files here, next step is to actually work with it in testing.
gbeeley
approved these changes
Feb 11, 2022
gbeeley
approved these changes
Feb 11, 2022
sheesania
approved these changes
Feb 14, 2022
gbeeley
approved these changes
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #39
Fixes #18